Wire WorkflowTokenAvailableConstraint into ConstraintCheckerService behind feature flag

[deepika-lalwani123]

Summary

Wires WorkflowTokenAvailableConstraint into ConstraintCheckerService behind Feature.WORKFLOW_TOKEN_CONSTRAINT (default false) for schedules triggered by program status notifications, including composite (AND/OR) triggers.

Changes

• Update ConstraintCheckerService:
  • Read Feature.WORKFLOW_TOKEN_CONSTRAINT via DefaultFeatureFlagsProvider(cConf) and construct WorkflowTokenAvailableConstraint with the configured wait timeout, mapping property key, required token key, and MetricsCollectionService.
  • Add containsProgramStatusTrigger(Trigger) to recursively detect ProgramStatusTrigger across AbstractSatisfiableCompositeTrigger (AndTrigger and OrTrigger) hierarchies.
  • Add getEffectiveConstraints(Job) and evaluate it in constraintsSatisfied so WorkflowTokenAvailableConstraint is appended at check time when the feature flag is enabled without persisting it onto schedules.
• Add unit tests in ConstraintCheckerServiceTest.

Testing

• Unit tests in ConstraintCheckerServiceTest.

[gemini-code-assist]

Code Review

This pull request introduces dynamic constraint injection in ConstraintCheckerService by appending a WorkflowTokenAvailableConstraint to jobs triggered by program status changes when the WORKFLOW_TOKEN_CONSTRAINT feature flag is enabled. Unit tests have been added to verify the trigger inspection and constraint injection logic. Feedback suggests optimizing getEffectiveConstraints to avoid redundant iterable concatenation and object allocation when the feature flag is disabled or the trigger is not a program status trigger.

[gemini-code-assist]

When the feature flag is disabled or the trigger is not a program status trigger, getEffectiveConstraints unnecessarily wraps the persisted constraints in a concatenated iterable with an empty list using Iterables.concat(persistedConstraints, ImmutableList.<Constraint>of()). Since this method is called for every job check in the polling loop, this redundant concatenation introduces unnecessary object allocation and iterator traversal overhead.

We can optimize this by changing the return type to Iterable<? extends Constraint> and returning persistedConstraints directly when the conditions are not met.

Suggested change

	Iterable<Constraint> getEffectiveConstraints(Job job) {
	List<? extends Constraint> persistedConstraints = job.getSchedule().getConstraints();
	if (!workflowTokenConstraintEnabled
	|| !containsProgramStatusTrigger(job.getSchedule().getTrigger())) {
	return Iterables.concat(persistedConstraints, ImmutableList.<Constraint>of());
	}
	return Iterables.concat(
	persistedConstraints, ImmutableList.<Constraint>of(workflowTokenAvailableConstraint));
	}
	Iterable<? extends Constraint> getEffectiveConstraints(Job job) {
	List<? extends Constraint> persistedConstraints = job.getSchedule().getConstraints();
	if (!workflowTokenConstraintEnabled
	|| !containsProgramStatusTrigger(job.getSchedule().getTrigger())) {
	return persistedConstraints;
	}
	return Iterables.concat(
	persistedConstraints, ImmutableList.of(workflowTokenAvailableConstraint));
	}