-
Notifications
You must be signed in to change notification settings - Fork 19
feat: add chainbench grpc subcommand for Solana Yellowstone gRPC benchmarks
#121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CSFeo
wants to merge
2
commits into
chainstacklabs:main
Choose a base branch
from
CSFeo:feat/grpc-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| """``chainbench grpc`` — Solana Yellowstone gRPC benchmarks. | ||
|
|
||
| Thin pass-through to the ``chainbench-grpc`` Rust binary (shipped on ``PATH`` in | ||
| the ChainBench Docker image). It forwards stdout/stderr and the process exit | ||
| code; the binary owns its own flags, validation, and ``--help``. Pass tool flags | ||
| after the mode, e.g.:: | ||
|
|
||
| chainbench grpc latency --url https://grpc.example.com --token TOKEN | ||
| chainbench grpc race -u https://a -t t1 -u https://b -t t2 --transactions 5000 | ||
| chainbench grpc latency --help # rendered by the binary | ||
| """ | ||
|
|
||
| import shutil | ||
| import subprocess | ||
| import sys | ||
|
|
||
| import click | ||
|
|
||
| GRPC_BIN = "chainbench-grpc" | ||
| GRPC_REPO = "https://github.com/chainstacklabs/chainbench-grpc" | ||
| MODES = ("race", "latency", "throughput", "slots", "full") | ||
|
|
||
|
|
||
| def _run(mode: str, args: tuple[str, ...]) -> None: | ||
| exe = shutil.which(GRPC_BIN) | ||
| if exe is None: | ||
| raise click.ClickException( | ||
| f"`{GRPC_BIN}` not found on PATH. It ships in the ChainBench Docker " | ||
| f"image; for local use install it from {GRPC_REPO}" | ||
| ) | ||
| completed = subprocess.run([exe, mode, *args]) | ||
| sys.exit(completed.returncode) | ||
|
|
||
|
|
||
| @click.group( | ||
| name="grpc", | ||
| help=( | ||
| "Solana Yellowstone gRPC benchmarks (delegates to the chainbench-grpc " | ||
| "binary). Flags after the mode are passed through to the binary, e.g. " | ||
| "`grpc latency --url URL --token TOKEN`." | ||
| ), | ||
| ) | ||
| def grpc() -> None: | ||
| pass | ||
|
|
||
|
|
||
| def _register(mode: str) -> None: | ||
| @grpc.command( | ||
| name=mode, | ||
| help=f"Run chainbench-grpc `{mode}` (flags are passed through to the binary).", | ||
| context_settings={"ignore_unknown_options": True, "allow_extra_args": True}, | ||
| add_help_option=False, # let the binary render its own --help | ||
| ) | ||
| @click.argument("args", nargs=-1, type=click.UNPROCESSED) | ||
| def _cmd(args: tuple[str, ...]) -> None: | ||
| _run(mode, args) | ||
|
|
||
|
|
||
| for _mode in MODES: | ||
| _register(_mode) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Run the production image as a non-root user.
The new binary is added to an image that still defaults to
root. Create a dedicated runtime user and switch to it beforeENTRYPOINT; otherwise vulnerabilities in the CLI, benchmark binary, or dependencies have root privileges.🤖 Prompt for AI Agents
Source: Linters/SAST tools