fix: preserve owned lifetime of pool transactions - #39
Open
torchello wants to merge 1 commit into
Open
Conversation
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlx::Pool::begin()returns an ownedTransaction<'static, DB>, but the wrapper shortens that lifetime to the borrow of&self. This prevents returning a transaction from a helper or storing it in an owned guard, even though its connection already belongs to the transaction.Preserve SQLx's
'staticreturn lifetime. The implementation and transaction behavior remain the same. A regression test requires the owned return type at compile time, drops the originating pool handle, then executes a query and rolls back successfully.Validation (Rust 1.97.1, SQLx 0.9):
cargo test --features "sqlite,runtime-tokio" --test sqlite— 117 passed.cargo clippy --all-targets --all-features -- -D warnings— passed.cargo fmt --all -- --check— passed.