Repository navigation
Conversation
cjbarth
added a commit
that referenced
this pull request
Oct 13, 2026
…Node version Node 16 refuses PKCS #8 data labelled RSA PRIVATE KEY, and later versions read it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression and fix for XMLDSig reference digests that omitted ordinary attributes whose names begin with
xmlns.checkSignature()previously returned true afterxmlnsRole="user"in a signed element was changed to"admin", with either inclusive or exclusive C14N. The canonicalizers now exclude only actual namespace declarations (xmlnsandxmlns:*), and ancestor namespace collection uses the same distinction.The public regression tests failed before the fix: 516 passing, 2 failing in Actions run 37001060089 (Node 24); the added ancestor namespace test also failed in run 37001256907 (Node 16). Final CI pending. Existing signatures over XML containing such ordinary attributes may not verify after the fix, as their digest was computed from incomplete canonical bytes.
This draft fork PR is for red/green CI validation. The intended release PR will target
node-saml/xml-crypto:masteronce repository access is enabled.