You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci(repo): watch every checked-in package file in builds by default - #10659
Turbo decides whether to rebuild a package by checking a list of its files. We wrote those lists by hand, and they missed files that do change the build. Editing one of them didn't trigger a rebuild, so CI kept using the old build. The missed files included:
@clerk/react's build-utils/parseVersionRange.ts, which its build config imports
@clerk/nextjs's package.esm.json and package.cjs.json, which its build copies into dist
the small package.json files behind subpath imports like @clerk/nextjs/server
shipped folders like @clerk/ui's register/ and @clerk/clerk-js's no-rhc/
the Android and iOS code in the Expo native packages
@clerk/express's tsdown.config.mts
Builds now watch every checked-in file in the package, which is Turbo's recommended setup ($TURBO_DEFAULT$), minus the files that can't change the build: tests, mocks, snapshots, Markdown at the package root, docs/, the license, and lint, test and docs configs. New files are watched without anyone having to add them.
clerk-js, express, mosaic and ui had their own lists. They now use the shared one. packages/express/turbo.json had nothing else in it, so it's deleted.
@clerk/shared's build bakes in the version numbers from clerk-js's and ui's package.json. Those files sit outside shared, so Turbo never looked at them, and a version bump could leave shared with the old numbers. packages/shared/turbo.json now adds those two files to its list.
Builds also told Turbo to save scripts/** and */package.json from each package, but no build writes there. Those paths hold checked-in files, so a cache hit could put an old copy back over a local edit. Editing @clerk/upgrade's scripts/generate-guide.js and then building quietly restored the old version. Builds now save only dist/**.
Everything that was watched before is still watched, except one .spec.ts test file in ui. Going by the last 300 commits on main, this adds about 3% more rebuilds, mostly from Expo native code changes that used to be missed.
#10648 also edits packages/express/turbo.json. Whichever of the two merges second should keep this PR's deletion. The integration suites in #10648, #10653 and #10661 rerun only when a build's watched files change, so this PR should merge before them.
Checklist
pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
Reviewing files that changed from the base of the PR and between d98cdac and 46f4ecd.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
The root Turbo build configuration now uses $TURBO_DEFAULT$ as its input basis and changes its exclusions. Its outputs now include only dist/**. Package-specific Turbo configurations or entries were removed from Clerk JS, Express, Mosaic, and UI. The shared package adds a build configuration that extends the root configuration and adds two package manifests to its inputs. The changes also add two YAML document separators to a changeset file.
clerk/javascript#10667: Both PRs change Turbo task hashing. This PR removes package-specific build tasks that the other PR configures with task-specific environment inputs.
clerk/javascript#10648: Both PRs change the Express build task inputs. This PR deletes the Express Turbo configuration that the other PR updates.
clerk/javascript#10669: Both PRs change Turbo build outputs. This PR changes the default outputs, while the other PR adds an Astro-specific output.
Merge Risk: Minimal · previous review d98cd
No merge-blocking issue was established. The broader build-output check remains incomplete.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly and concisely summarizes the main change: Turbo builds now watch checked-in package files by default.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description directly explains the Turbo input and output configuration changes, affected packages, build-cache behavior, testing status, and merge coordination.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.
Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.
Before, editing each of the eight listed files left its package's build hash unchanged; after, every edit changes the hash.
Merge-base
This PR d98cdac6
Also checked · 4 match
No previously watched input is dropped Tests, docs and tooling configs stay excluded Cache hit no longer reverts checked-in scripts Shared rebuilds on clerk-js or ui version bump
Proof on d98cdac6 (from ce73d638) · Did Proof get it right? Yes · No
Package builds listed the files they watch, so a build file missing from the list could change without a rebuild. React's build helper, Next.js's copied package.json files, shipped subpath entries and native sources were all unwatched. Builds now start from Turbo's default of every checked-in file and exclude tests, docs and tooling that can't change the output.
The scripts/** and */package.json build outputs matched no generated
files, only checked-in sources, so a cache hit could restore an old copy
over a local edit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Turbo decides whether to rebuild a package by checking a list of its files. We wrote those lists by hand, and they missed files that do change the build. Editing one of them didn't trigger a rebuild, so CI kept using the old build. The missed files included:
@clerk/react'sbuild-utils/parseVersionRange.ts, which its build config imports@clerk/nextjs'spackage.esm.jsonandpackage.cjs.json, which its build copies intodistpackage.jsonfiles behind subpath imports like@clerk/nextjs/server@clerk/ui'sregister/and@clerk/clerk-js'sno-rhc/@clerk/express'stsdown.config.mtsBuilds now watch every checked-in file in the package, which is Turbo's recommended setup (
$TURBO_DEFAULT$), minus the files that can't change the build: tests, mocks, snapshots, Markdown at the package root,docs/, the license, and lint, test and docs configs. New files are watched without anyone having to add them.clerk-js,express,mosaicanduihad their own lists. They now use the shared one.packages/express/turbo.jsonhad nothing else in it, so it's deleted.@clerk/shared's build bakes in the version numbers fromclerk-js's andui'spackage.json. Those files sit outsideshared, so Turbo never looked at them, and a version bump could leavesharedwith the old numbers.packages/shared/turbo.jsonnow adds those two files to its list.Builds also told Turbo to save
scripts/**and*/package.jsonfrom each package, but no build writes there. Those paths hold checked-in files, so a cache hit could put an old copy back over a local edit. Editing@clerk/upgrade'sscripts/generate-guide.jsand then building quietly restored the old version. Builds now save onlydist/**.Everything that was watched before is still watched, except one
.spec.tstest file inui. Going by the last 300 commits onmain, this adds about 3% more rebuilds, mostly from Expo native code changes that used to be missed.#10648 also edits
packages/express/turbo.json. Whichever of the two merges second should keep this PR's deletion. The integration suites in #10648, #10653 and #10661 rerun only when a build's watched files change, so this PR should merge before them.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change