Skip to content

fix(tf-smurf): updated tf smurf workflow to skip apply/approver if we use plan_only #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harshall-cd wants to merge 4 commits into from
Closed

fix(tf-smurf): updated tf smurf workflow to skip apply/approver if we use plan_only #401

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e685ef2
fix: updated tf smurf workflow to skip apply/approver if we use plan_…
harshall-cd Jul 1, 2026
a86a024
fix: workflow test
harshall-cd Jul 3, 2026
3f6b95a
fix: workflow test
harshall-cd Jul 3, 2026
aaa5752
fix: updated workflow apply/approve condition on plan_only
harshall-cd Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/tf-smurf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ on:
required: false
type: string
description: 'Terraform var file directory. e.g. vars/dev.tfvars'
destroy:
terraform_destroy:
required: false
type: boolean
default: false
Expand Down Expand Up @@ -206,7 +206,7 @@ jobs:
smurf stf plan --dir=${{ inputs.terraform_directory }}
- name: ⏳ Approval Before Apply
if: inputs.terraform_destroy != 'true'
if: ${{ !inputs.terraform_destroy && !inputs.plan_only }}
uses: trstringer/manual-approval@v1
with:
secret: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -216,15 +216,15 @@ jobs:
issue-title: "Approve Terraform Apply"

- name: 🚀 Terraform Apply
if: inputs.terraform_destroy != 'true'
if: ${{ !inputs.terraform_destroy && !inputs.plan_only }}
run: |
smurf stf apply --auto-approve --dir=${{ inputs.terraform_directory }}
###############################################
# DESTROY → APPROVAL → DESTROY APPLY
###############################################
terraform-destroy:
if: inputs.terraform_destroy == 'true'
if: ${{ inputs.terraform_destroy == true }}
runs-on: ubuntu-latest

steps:
Expand Down
Loading