Repository navigation
Conversation
|
| Name | Type |
|---|---|
| capnweb | Minor |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary
ArrayBuffercopies acrossjsonCompatibleWithBytesandMessagePort(structuredClonable) transports:Zero-copy
jsonCompatibleWithBytesserialization (Devaluator.devaluateImpl):Uint8Arrayviews (bytes.byteOffset !== 0 || bytes.byteLength !== bytes.buffer.byteLength) were copied withnew Uint8Array(bytes)at bothstructuredClonableandjsonCompatibleWithByteslevels soMessagePort.postMessagewouldn't clone an entire shared backing buffer (such as Node'sBufferpool orWebAssembly.Memory).jsonCompatibleWithBytestransports inspect[bytes.buffer, bytes.byteOffset, bytes.byteLength]directly rather than structured-cloningbytes.buffer, soDevaluatornow keeps the exact view atjsonCompatibleWithByteslevel and only copies un-transferred partial views atstructuredClonablelevel.Zero-copy
ArrayBufferViewdeserialization (Evaluator.evaluateImpl):Evaluatoralways calledbytes.buffer.slice(bytes.byteOffset, bytes.byteOffset + bytes.byteLength)before constructing typed arrays orDataView, even whenbyteswas already a rawUint8ArrayatjsonCompatibleWithBytesorstructuredClonablelevel.Uint8Array(not base64-decoded into Node's sharedBufferpool), native endianness is little-endian (orelementSize === undefined), andbytes.byteOffsetis aligned toelementSize, typed array andDataViewviews are constructed directly on(bytes.buffer, bytes.byteOffset, ...)without slicing.ArrayBufferpayloads continue to slice subviews sobyteLengthand indexable bounds match the serialized view.Opt-in transferable
ArrayBuffers overMessagePort(transferArrayBuffer):transferArrayBuffer(viewOrBuffer)to mark anArrayBuffer(or the backingArrayBufferof anArrayBufferView) for zero-copy transfer overMessagePorttransports.Devaluatorpreserves partial views on marked buffers without copying, andMessagePortTransport.send()collects and consumes markedArrayBuffers into thepostMessage(message, transfer)transfer list (with a zero-costbooleanfast-path whentransferArrayBuffer()has not been called).