fix(response-store): stabilize cached variant selection - #3308
Merged
Merged
Conversation
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
Member
Author
|
/bigbonk review for issues You have an eight-minute time limit. Finish the review and post all findings within eight minutes. |
Contributor
|
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The Response Store lookup URL already partitions every framework request selector. Giving each selector a fixed marker keeps cache variant selection consistent without forwarding large request values.
Testing
vp check packages/cloudflare/src/cache/response-store-adapter.worker.ts tests/cloudflare-response-store-worker.test.tsvp test run tests/cloudflare-response-store-worker.test.tspnpm --filter @vinext/cloudflare exec vitest run tests/response-store-adapter.e2e.test.ts(17 tests)vp run @vinext/cloudflare#build