fix(dev): optimize Chakra UI barrel imports - #3317
Merged
Merged
Conversation
Member
Author
|
/bigbonk review for issues |
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
Contributor
|
LGTM! |
Contributor
|
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@chakra-ui/reactin vinext's default barrel-import optimization"use client"module instead of evaluating the root barrel underreact-serverRoot cause
Chakra UI v3 publishes a directive-less root barrel that re-exports client modules. In the Cloudflare-backed dev runner, importing
Boxfrom that barrel allowed itscreateContext()path to execute with thereact-serverruntime, wherecreateContextis unavailable. Production builds already avoided the failure through static analysis.Next.js supports this class of package through
experimental.optimizePackageImports; vinext's existing equivalent already handles Radix and other barrels. Adding Chakra to vinext's compatibility defaults routes named imports directly to Chakra's client-marked module.Validation
(0, import_react_react_server.createContext) is not a functionvp test run tests/optimize-imports-integration.test.ts tests/optimize-imports.test.ts(44 passed)vp check packages/vinext/src/plugins/optimize-imports.ts tests/optimize-imports-integration.test.tsvp run vinext#buildNO FINDINGSverdictsCloses #3316