fix(cloudflare): prewarm KV through deployed Workers - #3324
Conversation
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
|
Performance benchmarksCompared 1 improved · 0 regressed · 5 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
|
/bigbonk review for issues Time limit: 10 minutes. Complete the review and post all findings within that limit. |
|
Posted 3 actionable inline findings. Targeted tests passed: 110/110. |
|
/bigbonk review for issues Time limit: 10 minutes. Complete the review and post all findings within that limit. |
|
Posted 1 new actionable inline finding. Targeted tests passed: 180/180. |
|
/bigbonk review for issues Time limit: 10 minutes. Complete the review and post all findings within that limit. |
|
Posted 1 new actionable inline finding. Targeted tests passed: 180/180. |
|
/bigbonk review for issues Time limit: 10 minutes. Complete the review and post all findings within that limit. |
|
Posted 1 new actionable inline finding. |
|
/bigbonk review for issues Time limit: 10 minutes. Complete the review and post all findings within that limit. |
|
LGTM! |
Summary
Testing
vp test run tests/cache-adapters-config.test.ts tests/cdn-cache.test.ts tests/deploy-prerender-config.test.ts tests/cloudflare-cdn-warm.test.ts(134 tests)vp checkvp run vinext#buildvp run @vinext/cloudflare#buildVINEXT_CACHE_BACKEND=kv VINEXT_KV_APP_PREFIX=local-e2e vp run response-store-demo#buildMISSthenHIT, no Workers Cache entrypoint, build identity present, and no-store route reused the page cached-function UUIDVINEXT_CACHE_BACKEND=workers-cache VINEXT_KV_APP_PREFIX=local-workers-cache vp run response-store-demo#buildgit diff --check