Mark jsg::{Async}Generator visitable - #7213
Merged
Merged
Conversation
jasnell
force-pushed
the
jasnell/fixup-memory-leaks-in-streams
branch
from
September 1, 2026 21:50
ce4ee0b to
139199d
Compare
Contributor
|
@jasnell Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
Collaborator
Author
|
/bonk roast this PR |
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
jasnell
force-pushed
the
jasnell/fixup-memory-leaks-in-streams
branch
from
September 1, 2026 22:42
139199d to
937d28b
Compare
Collaborator
Author
|
/bonk ok, I believe that issue is resolved. check again |
Contributor
|
LGTM! |
jasnell
commented
Sep 1, 2026
jasnell
enabled auto-merge
September 1, 2026 23:43
jasnell
force-pushed
the
jasnell/fixup-memory-leaks-in-streams
branch
from
September 2, 2026 15:18
937d28b to
76ca2ad
Compare
guybedford
reviewed
Sep 3, 2026
guybedford
left a comment
guybedford
left a comment
Contributor
There was a problem hiding this comment.
Took a close look at the GC tracing changes and verified the behavioral surface of the IoContext/addFunctor removal empirically against main (notes inline). Overall the approach looks right.
One additional minor: TransformStreamDefaultController now keeps readableOwner/writableOwner rooted after error/terminate; they could be cleared at that point to release the wrappers earlier.
guybedford
approved these changes
Sep 3, 2026
In certain edge cases the lack of gc visitation can lead to memory leaks if certain promises go unresolved. There was also an infinite loop in the gc trace for certain TransformStrean constructions. By making ThenCatchPair traceable, removing the unnecessary addFunctor, and restoring JSG_VISITABLE_LAMBDA usage, we resolve the issues
jasnell
force-pushed
the
jasnell/fixup-memory-leaks-in-streams
branch
from
September 3, 2026 14:05
76ca2ad to
5908951
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.