tsan c++ and rust configurations - #7214
Open
mikea wants to merge 3 commits into
Open
Conversation
mikea
marked this pull request as draft
September 1, 2026 22:54
Contributor
|
@mikea Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
mikea
force-pushed
the
maizatskyi/2026-09-01-tsan-config
branch
3 times, most recently
from
September 2, 2026 16:39
485397f to
2a2d699
Compare
mikea
requested review from
fhanau and
npaun
and
a balanced review from Copilot
September 2, 2026 16:55
npaun
reviewed
Sep 2, 2026
npaun
reviewed
Sep 2, 2026
| tags = ["manual"], | ||
| target_compatible_with = ["//build/platforms:sanitizer_thread"], | ||
| target_triple = _TARGET_TRIPLE, | ||
| visibility = ["//src/rust/tsan-test:__pkg__"], |
Member
There was a problem hiding this comment.
TIL you could have weird visibility expressions like this.
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
Contributor
|
I'm Bonk, and I've done a quick review of your PR. Adds C++ and Rust ThreadSanitizer build configurations and an instrumented Rust standard library.
|
npaun
approved these changes
Sep 2, 2026
mikea
marked this pull request as ready for review
September 2, 2026 17:01
There was a problem hiding this comment.
🟡 Changes recommended
The Rust toolchain omits rustc’s required codegen backend, and the test hard-codes main-repository runfile paths.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds Linux x86_64 TSan support across C++ and Rust, including an instrumented Rust standard library and integration test.
Changes:
- Adds sanitizer platforms and Bazel configurations.
- Builds a TSan-instrumented Rust standard library and toolchain.
- Adds V8 compatibility patch and race-detection test.
File summaries
| File | Description |
|---|---|
.bazelrc |
Configures ASan/TSan builds. |
build/deps/rust.MODULE.bazel |
Exposes nightly Rust tools and sources. |
build/deps/v8.MODULE.bazel |
Registers the V8 TSan patch. |
build/platforms/BUILD.bazel |
Defines sanitizer constraints and platforms. |
build/rust/BUILD.bazel |
Defines the custom TSan Rust toolchain. |
build/rust/build_std.bzl |
Implements instrumented standard-library rules. |
build/rust/build_std.sh |
Builds and stages instrumented Rust libraries. |
patches/v8/0041-Fix-TSan-build-without-the-V8-sandbox.patch |
Guards sandbox-only V8 handling. |
src/rust/tsan-test/BUILD.bazel |
Declares the TSan integration test. |
src/rust/tsan-test/race.rs |
Provides a deliberate Rust data race. |
src/rust/tsan-test/verify.sh |
Validates instrumentation and race reporting. |
Review details
Suppressed comments (1)
src/rust/tsan-test/verify.sh:11
- This second
_mainpath has the same external-repository failure: under a parent Bazel workspace it does not resolve the:racerunfile. Resolve it throughTEST_WORKSPACEinstead.
race="$TEST_SRCDIR/_main/src/rust/tsan-test/race"
- Files reviewed: 11/11 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mikea
force-pushed
the
maizatskyi/2026-09-01-tsan-config
branch
from
September 2, 2026 17:33
2a2d699 to
f1d93d4
Compare
mikea
force-pushed
the
maizatskyi/2026-09-01-tsan-config
branch
from
September 2, 2026 17:37
f1d93d4 to
da9d022
Compare
mikea
enabled auto-merge
September 2, 2026 19:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
borrows the idea of recent build-std change downstream to build tsan-instrumented rust stdlib.