feat: inject Dynatrace OneAgent for bound dynatrace service - #230
Open
silvestre wants to merge 1 commit into
Open
feat: inject Dynatrace OneAgent for bound dynatrace service#230silvestre wants to merge 1 commit into
silvestre wants to merge 1 commit into
Conversation
# Issue: The binary-buildpack cannot instrument arbitrary binaries with Dynatrace OneAgent the way the go-buildpack does. # Fix: Register the `libbuildpack-dynatrace` hook (default `process` module) so a bound Dynatrace service triggers OneAgent download at stage time and `LD_PRELOAD` at launch. Wired into both CLIs, added an integration suite plus mock tenant fixture, and documented the binding and dynamic-linking caveat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register the
libbuildpack-dynatracehook so a bound Dynatrace service triggers the OneAgent download at stage time andLD_PRELOADit at launch.When deploying a binary, it can very useful to have Dynatrace support for obsevability. I believe all other buildpacks in the cloudfoundry org have Dynatrace support built-in. Fixes: #229
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
masterbranchI have added an integration test