Repository navigation
Fixes #3736. - #4154
Open
strehle wants to merge 1 commit into
Open
Fixes #3736.#4154strehle wants to merge 1 commit into
strehle wants to merge 1 commit into
Conversation
strehle
commented
Nov 11, 2026
strehle
commented
Member
- Validate identity-zone subdomains on create and update, rejecting unsafe values with HTTP 422.
- Preserve the default UAA zone’s empty subdomain and deletion of legacy invalid zones.
- Add regression tests, correct affected test fixtures, and update documentation.
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
fhanik
previously approved these changes
Nov 12, 2026
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
strehle
force-pushed
the
fix/issue/3736
branch
from
November 12, 2026 17:27
752375d to
3e09a62
Compare
strehle
force-pushed
the
fix/issue/3736
branch
from
November 12, 2026 18:23
3e09a62 to
3ff0dd2
Compare
strehle
force-pushed
the
fix/issue/3736
branch
2 times, most recently
from
November 12, 2026 19:51
032f651 to
ab69a9d
Compare
strehle
force-pushed
the
fix/issue/3736
branch
from
November 12, 2026 20:08
ab69a9d to
be8004f
Compare
strehle
force-pushed
the
fix/issue/3736
branch
from
November 12, 2026 20:29
be8004f to
f9d72ce
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The migration rewrites persisted identity-zone subdomains and resolves legacy uniqueness collisions across three database engines, creating production data-integrity and database-specific behavior risks that require human review and real-database validation.
No open issues 🎉
1 resolved since last review
Review effort: Lite
duanemay
reviewed
Nov 13, 2026
| hostnames | ||
| .forEach( | ||
| entry -> this.defaultZoneHostnames.add(entry.toLowerCase()) | ||
| entry -> this.defaultZoneHostnames.add(entry.toLowerCase(Locale.ROOT)) |
Member
There was a problem hiding this comment.
This could make existing zones inaccessible or route requests to a different zone if their subdomains were stored using a different system locale.
duanemay
reviewed
Nov 13, 2026
| } | ||
|
|
||
| private static Stream<Arguments> invalidSubdomains() { | ||
| return Stream.of(null, "", " ", "my zone", "my.zone", "my_zone", "-zone", "zone-", |
Member
There was a problem hiding this comment.
Was it intentional to disallow underscores for existing zones? This would prevent updates to zones that already have an underscore in their subdomain.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.