chore: [preview] multi-column sort dev page (do not merge)#4685
Draft
gethinwebster wants to merge 4 commits into
Draft
chore: [preview] multi-column sort dev page (do not merge)#4685gethinwebster wants to merge 4 commits into
gethinwebster wants to merge 4 commits into
Conversation
gethinwebster
force-pushed
the
dev-v3-gethinw-multi-column-sort-preview
branch
from
2498fb8 to
8870775
Compare
gethinwebster
force-pushed
the
dev-v3-gethinw-multi-column-sort-preview
branch
from
8870775 to
6545236
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4685 +/- ##
==========================================
- Coverage 97.57% 97.57% -0.01%
==========================================
Files 948 952 +4
Lines 30507 30679 +172
Branches 11164 11241 +77
==========================================
+ Hits 29767 29934 +167
- Misses 693 738 +45
+ Partials 47 7 -40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gethinwebster
force-pushed
the
dev-v3-gethinw-multi-column-sort-preview
branch
from
9b940c9 to
788976b
Compare
gethinwebster
force-pushed
the
dev-v3-gethinw-multi-column-sort-preview
branch
from
788976b to
6745822
Compare
Add multi-column sorting to Table, activated by shift-clicking sortable column headers or via a per-column sort menu. - Per-column sort menu: set ascending/descending direction (shown as a checked state), add to / remove from the multi-column sort, with disabled-reason tooltips on unavailable actions. - Priority badges on sorted column headers and a Clear sort control. - A polite live region announcing the current sort order (and when sorting is cleared), reading localized header text from the DOM and joining columns with locale-appropriate separators. - Focus management so clearing the sort keeps keyboard focus on a sortable column header instead of dropping to the document body. - Styling fixes so the sort icon and priority badge do not overlap truncated header text in narrow columns. - i18n strings for all new labels and screen reader announcements, plus test-utils and unit tests covering the new behavior.
Real translations for the eight original multi-column sort strings, handed back from AWS-UI-Components-I18n (CR-286059617). Covers 12 locales; en/en-GB already carried the English source values, and Thai (th) is not yet translated.
…[DROP before PR] Placeholder (English) values for the two new sort disabled-reason strings and the three live-region announcement strings, across the 13 supported locales. Real translations arrive via the Totoro handback; drop this commit before the PR.
…, do not merge] Vendors the unpublished collection-hooks multi-sort build as vendor/collection-hooks-1.0.0.tgz and points the dependency at it via a repo-relative file: path so the preview deploy (npm i + quick-build) resolves the unpublished multi-sort API. Also swaps in the expanded useCollection dev page (with I18nProvider) for the bug bash. Dropped in the real feature PR.
gethinwebster
force-pushed
the
dev-v3-gethinw-multi-column-sort-preview
branch
from
6745822 to
1f0cc56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview-only PR — do not merge.
Deploys a preview of the multi-column sort dev page (
pages/table/multi-column-sort.page.tsx) wired touseCollectionwithmultiColumn: true.Because the multi-sort
useCollectionAPI isn't published yet (depends on cloudscape-design/collection-hooks#155), this branch vendors the built collection-hooks asvendor/collection-hooks-1.0.0.tgzand points the dependency at it via a repo-relativefile:path so the preview deploy (npm i+quick-build) resolves the unpublished API.The real feature PR drops the vendored tarball and bumps
@cloudscape-design/collection-hooksto the published version once #155 releases.Opened solely to trigger the preview deploy workflow.