Repository navigation
enclaveapi: remove the unused URLEncode methods - #88
Merged
Merged
Conversation
AttestationDoc.URLEncode and AuctionAttestationDoc.URLEncode have no callers and discard the json.Marshal error. Remove them and the encoding/json and net/url imports that only they used.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused cleanup is internally consistent and leaves required imports and call sites unaffected.
Review effort: Balanced
Findings: None
What changed in this PR
Removes two unused URL-encoding helpers and their obsolete imports from the enclave API.
Changes:
- Removes
URLEncodemethods from both attestation types. - Removes unused
encoding/jsonandnet/urlimports.
| File | Description |
|---|---|
enclaveapi/types.go |
Removes unused exported methods and imports. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AttestationDoc.URLEncodeandAuctionAttestationDoc.URLEncodefromenclaveapi/types.go. Neither method has a caller in this repository, in cloudx-io/openarbiter or in the in-org repositories that import this module. Both calljson.Marshaland discard its error, so a marshal failure returns an empty string instead of an error.encoding/jsonandnet/urlimports inenclaveapi/types.gowere used only by these methods and are removed with them. Struct fields keep theirjsontags.Pre-merge checklist
origin/main, an unfilteredgit grep -nw URLEncodefinds only the two definitions in this repository and nothing in cloudx-io/openarbiter or the in-org importers. On this branch it finds nothing.go list -deps ./enclave/...(host andGOOS=linux) is identical before and after. Built as indocker.ymlwith-buildvcs=falsefrom the same path, the linux/amd64 and linux/arm64 enclave binaries are not byte-identical, but their symbol tables (names and sizes) are identical. The CI build embeds the commit SHA, so the PCRs for the merge commit change as they do for every commit.go build ./...andgo vet ./....mise run //:lint(0 issues).mise run //:test.git diff --checkpasses.aa87986.Post-deploy/apply verification
mainfor the merge commit pass, including theupdate-pcrsjob. (merge commit 9809057: Go, Docker Build and Build EIF green; update-pcrs pushed 0488919)