Skip to content

Update Vietnamese translations#1053

Merged
lw merged 1 commit into
cms-dev:masterfrom
kuroni:master
Nov 1, 2018
Merged

Update Vietnamese translations#1053
lw merged 1 commit into
cms-dev:masterfrom
kuroni:master

Conversation

@kuroni

@kuroni kuroni commented Oct 23, 2018

Copy link
Copy Markdown
Contributor

Fix spacing issues on several multi-line translations.


This change is Reviewable

@codecov

codecov Bot commented Oct 23, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1053 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
+ Coverage   62.04%   62.07%   +0.03%     
==========================================
  Files         228      228              
  Lines       16434    16434              
==========================================
+ Hits        10197    10202       +5     
+ Misses       6237     6232       -5
Flag Coverage Δ
#functionaltests 46.15% <ø> (-0.01%) ⬇️
#unittests 43.16% <ø> (-0.03%) ⬇️
Impacted Files Coverage Δ
cms/io/PsycoGevent.py 62.85% <0%> (-2.86%) ⬇️
cms/io/priorityqueue.py 92.7% <0%> (-2.19%) ⬇️
cms/grading/scoring.py 74.69% <0%> (-1.21%) ⬇️
cms/server/admin/handlers/task.py 39.84% <0%> (-1.18%) ⬇️
cms/io/triggeredservice.py 84.21% <0%> (-1.06%) ⬇️
cms/server/admin/handlers/base.py 68.13% <0%> (-1.02%) ⬇️
cms/service/ResourceService.py 57.6% <0%> (-0.93%) ⬇️
cms/db/util.py 51.51% <0%> (-0.76%) ⬇️
cms/service/esoperations.py 81.56% <0%> (-0.71%) ⬇️
cms/db/filecacher.py 77.7% <0%> (-0.66%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3a1276...f47a91d. Read the comment docs.

@kuroni kuroni closed this Oct 23, 2018
@kuroni kuroni reopened this Oct 23, 2018
@lw

lw commented Oct 23, 2018 via email

Copy link
Copy Markdown
Member

@tuankiet65

tuankiet65 commented Nov 1, 2018

Copy link
Copy Markdown
Contributor

Since #1052 is merged this pull request might as well be closed?

@lw

lw commented Nov 1, 2018

Copy link
Copy Markdown
Member

This PR was opened to fix up some issues in #1052. I'm waiting for @kuroni to confirm that this is done before I review it.

@kuroni

kuroni commented Nov 1, 2018

Copy link
Copy Markdown
Contributor Author

This is done actually, sorry for the late reply.

@lw lw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lw lw merged commit eea227f into cms-dev:master Nov 1, 2018
@lw

lw commented Nov 1, 2018

Copy link
Copy Markdown
Member

Thanks, sorry for the misunderstanding, pushed to master and v1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants