Repository navigation
feat(confighub): return the standard rule builder from FromConfigHub - #60
Merged
Merged
Conversation
Select and MountAt are valid on a ConfigHub rule: the class key decides which object the server returns, and both then apply to that object on the client like on any other rule. Whether they make sense is the developer's decision, so the wrapper builder that hid them is removed. Schema registration ignores both and always reports the full type of the rule under its class name or alias. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FromConfigHubreturns the normalProviderRuleBuilder<...>again; theConfigHubRuleBuilderwrapper is removed.SelectandMountAttherefore work as on every other rule and apply to the class object the server returns.Select/MountAtand always reports the full type fromFor<T>()under its class name or alias. Only the "no Select" guard was removed; the conflict error for one key with different types is unchanged.Why
The class key decides which object ConfigHub delivers. A type can still lie below a path inside that object (
Select), or the delivered object can belong to a nested property of the bound type (MountAt). Both are rare but valid, and the decision belongs to the developer, as with any other provider.Test plan
dotnet test ./src -c Release --filter "Type!=Performance"— all greenSelectandMountAttake effect on delivery while the registered schema stays the full typenode website/scripts/sync-skill.mjs --check🤖 Generated with Claude Code