Repository navigation
fix: follow a selected path that disappears from its source at runtime - #62
Merged
Merged
Conversation
The change handler swallowed the KeyNotFoundException of a failed Select as "nothing changed", so the transform cache stayed valid and every later recompute kept serving the bytes from before the path was removed. Only a restart corrected it, and health stayed Healthy. A well-formed document without the selected path is new content. It now drops the cache and publishes a change, so the next recompute goes through the fetch path and decides optional versus required exactly as it does at startup. Malformed documents caught mid-write are still ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.Select(...)kept serving its previous values when the selected path was removed from the source at runtime. No error, no notification, health stayedHealthy; only a restart corrected it.TransformCache.ProcessProviderChangeswallowed theKeyNotFoundExceptionof the failed select as "nothing changed", so the cache stayed valid and later recomputes never fetched again.Degraded), a required rule keeps the last good snapshot and is reported. Repeated changes that still lack the path trigger only one recompute. Malformed documents caught mid-write are still ignored.Behaviour change
A source that delivers
{}at runtime (for example a deleted file) now also resets aSelectrule to its defaults, matching rules withoutSelect.Test plan
SelectedSectionRemovedTests(optional rule incl. recovery,Select+MountAt, required rule) — all three failed before the fixdotnet test ./src -c Release --filter "Type!=Performance"— all green🤖 Generated with Claude Code