Repository navigation
Improve PHP version requirement to ^7.1 || ~8.0.0 || ~8.1.0 - #301
Closed
florianeckerstorfer wants to merge 3 commits into
Closed
florianeckerstorfer wants to merge 3 commits into
florianeckerstorfer wants to merge 3 commits into
Conversation
Member
Author
|
Added PHP 8.2.x to version range, since the unit tests are currently passing for it |
Ocramius
suggested changes
Jan 15, 2022
Ocramius
left a comment
Ocramius
left a comment
There was a problem hiding this comment.
Note: you may want to run composer update --lock
| ], | ||
| "require": { | ||
| "php": ">=7.1", | ||
| "php": "^7.1 || ~8.0.0 || ~8.1.0 || ~8.2.0", |
There was a problem hiding this comment.
Careful with 8.2.0: I suggest holding off until it reaches RC, around october 2022.
Until then, any BC break is still possible.
|
Remember |
|
@florianeckerstorfer is this closed on purpose? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up in the comments to a recently closed PR and I would appreciate your input on this.