Add verification before enabling donations on project - #514
Merged
Conversation
sbatson5
reviewed
Nov 30, 2016
| defmodule CodeCorps.StripeService.StripeConnectPlanService do | ||
| alias CodeCorps.Organization | ||
| alias CodeCorps.Project | ||
| alias CodeCorps.{Project, StripeConnectPlan} |
| @invalid {:error, :project_not_ready} | ||
|
|
||
| defp do_validate(%Project{ | ||
| donation_goals: [_h | _t], |
There was a problem hiding this comment.
Do we need to specify head and tail here?
Contributor
There was a problem hiding this comment.
@sbatson5 no, this just validates that it's non-empty.
joshsmith
approved these changes
Dec 1, 2016
| @invalid {:error, :project_not_ready} | ||
|
|
||
| defp do_validate(%Project{ | ||
| donation_goals: [_h | _t], |
Contributor
There was a problem hiding this comment.
@sbatson5 no, this just validates that it's non-empty.
joshsmith
force-pushed
the
511-add-verification-status-to-connect-account
branch
from
December 1, 2016 05:53
db2b11a to
616cdf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Handles the API part of verifying that a project can enable donations. Done by adding a
Validatormodule which ensures all project fields and relationships have the correct values. Similar in how it was implemented in #513References
Progress on: #511