Repository navigation
feat(cli): introduce the onlyPlugins option - #246
Merged
Merged
Conversation
BioPhoton
requested changes
Nov 13, 2023
BioPhoton
left a comment
BioPhoton
left a comment
Collaborator
There was a problem hiding this comment.
left a small comment. As the options does not apply for all commands e.g. upload we should put the type and options in the specific command.
IKatsuba
force-pushed
the
only-plugins-option
branch
from
November 13, 2023 23:12
7437190 to
28b135a
Compare
BioPhoton
reviewed
Nov 13, 2023
BioPhoton
left a comment
BioPhoton
left a comment
Collaborator
There was a problem hiding this comment.
I have one question on where to put the CLI option schema.. but no good answer. :D
Looks good otherwise!!
🎉🎉🎉
matejchalk
requested changes
Nov 14, 2023
Collaborator
|
PR closed please merge |
IKatsuba
force-pushed
the
only-plugins-option
branch
3 times, most recently
from
November 15, 2023 21:15
ca4fa8c to
c7c614c
Compare
Contributor
Author
@BioPhoton I did it! |
BioPhoton
requested changes
Nov 15, 2023
matejchalk
reviewed
Nov 16, 2023
BioPhoton
previously approved these changes
Nov 16, 2023
IKatsuba
force-pushed
the
only-plugins-option
branch
from
November 16, 2023 19:47
f1677c7 to
c177aa8
Compare
IKatsuba
marked this pull request as ready for review
November 16, 2023 19:47
BioPhoton
previously approved these changes
Nov 16, 2023
IKatsuba
enabled auto-merge (squash)
November 16, 2023 20:21
matejchalk
reviewed
Nov 16, 2023
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
matejchalk
approved these changes
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #119
I modified
configMiddlewareand filtered all plugins. This allowed us not to modify the commands.