Repository navigation
refactor: global options location - #258
Merged
Merged
Conversation
BioPhoton
marked this pull request as ready for review
November 15, 2023 01:52
matejchalk
requested changes
Nov 15, 2023
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
BioPhoton
commented
Nov 15, 2023
BioPhoton
commented
Nov 15, 2023
BioPhoton
left a comment
BioPhoton
left a comment
Collaborator
Author
There was a problem hiding this comment.
Should be ready to go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR could go before #246 as there are a couple of questions it would resolve.
It includes:
cliandcoreOut of scope 😇: