Skip to content

fix(utils,cli): remove all mentions of the interactive option #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IKatsuba merged 1 commit into from
Nov 13, 2023
Merged

fix(utils,cli): remove all mentions of the interactive option #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/lib/implementation/model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Format, GlobalOptions } from '@code-pushup/models';

// type GeneralCliOnlyOptions = { progress: boolean }; // @TODO consider interactive and progress as CLI only options
// type GeneralCliOnlyOptions = { progress: boolean }; // @TODO consider progress as CLI only options
export type GeneralCliOptions = GlobalOptions;

export type CoreConfigCliOptions = {
Expand Down
8 changes: 4 additions & 4 deletions packages/utils/src/lib/execute-process.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,15 +86,15 @@ describe('objectToCliArgs', () => {
});

it('should handle boolean arguments', () => {
const params = { interactive: true };
const params = { progress: true };
const result = objectToCliArgs(params);
expect(result).toEqual(['--interactive']);
expect(result).toEqual(['--progress']);
});

it('should handle negated boolean arguments', () => {
const params = { interactive: false };
const params = { progress: false };
const result = objectToCliArgs(params);
expect(result).toEqual(['--no-interactive']);
expect(result).toEqual(['--no-progress']);
});

it('should handle array of string arguments', () => {
Expand Down
1 change: 0 additions & 1 deletion packages/utils/src/lib/execute-process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ export type CliArgsObject<T extends object = Record<string, ArgumentValue>> =
* const args = objectToProcessArgs({
* _: ['node', 'index.js'], // node index.js
* name: 'Juanita', // --name=Juanita
* interactive: false, // --no-interactive
* formats: ['json', 'md'] // --format=json --format=md
* });
*/
Expand Down