Repository navigation
Conversation
Runs for a merged release PR get a read-only cache token, so the cache save is denied and the push job finds nothing. No self-hosted release since 26.5.18 has reached Docker Hub. actions: write (codecov#1609) does not affect the cache token, so it is dropped.
juho9000
force-pushed
the
fix/self-hosted-release-artifact-handover
branch
from
October 9, 2026 18:07
7e6844e to
9f0ac07
Compare
Author
|
@thomasrockhu-codecov can you take a look at this? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every self-hosted release since 26.5.18 (26.6.11, 26.7.6, 26.9.10) is tagged on GitHub
but never reaches Docker Hub. The release workflow runs on
pull_request: closed, andsince June GitHub issues a read-only cache token to runs for a merged PR. The build job's
actions/cachesave is denied (cache write denied: token has no writable scopes), thejob stays green, and
Push Self Hosted Release Imagefails on the miss(https://github.com/codecov/umbrella/actions/runs/34520539245). #1609 added
actions: writetoGITHUB_TOKEN, which does not affect the cache token, so it isdropped here.
The build job now uploads the two tarballs as a run-scoped artifact and the push jobs
download it, the same way
_build-app.ymlhands the test image to_run-tests.yml.A push to main still builds each app once: the second invocation downloads the artifact
the first one uploaded instead of rebuilding. The download step in the first invocation
reports an expected failure (
continue-on-error).Test plan: merge, cut a release PR, confirm
push-api-imageandpush-worker-imagesucceed and the version tag appears on Docker Hub for
codecov/self-hosted-apiandcodecov/self-hosted-worker.Closes #2371
Closes codecov/feedback#963
Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Note
Medium Risk
Changes the release CI path that publishes self-hosted Docker images; wrong artifact wiring would block Hub pushes again, but scope is limited to workflow plumbing.
Overview
Fixes self-hosted release images not reaching Docker Hub when the workflow runs on a merged PR, because GitHub’s read-only cache token blocks saving the build job’s
actions/cacheentry while push jobs still expect a hit._self-hosted.ymlnow passesself-hosted-runtime.tarandself-hosted.tarbetween jobs via run-scoped artifacts (same idea as_build-app.yml→_run-tests.yml): the build job computes a stable artifact name fromoutput_directory, optionally downloads an artifact from an earlier job in the same workflow (continue-on-error), builds only on miss, then uploads with 1-day retention and no compression. Rolling and release push jobs download that artifact and load it; cache steps and explicit cache-miss failures are removed.self-hosted-release.ymldrops theactions: writepermission, which did not grant cache write access anyway.Reviewed by Cursor Bugbot for commit 9f0ac07. Bugbot is set up for automated code reviews on this repo. Configure here.