This repository was archived by the owner on Oct 7, 2025. It is now read-only.
Gitlab-stop-fix - #2654
Merged
Merged
Conversation
tymofiisobchenko
approved these changes
Sep 2, 2025
gregharvey
reviewed
Sep 2, 2025
| ansible.builtin.command: | ||
| cmd: /opt/gitlab/bin/gitlab-ctl stop sidekiq | ||
| register: sidekiq_stop | ||
| ignore_errors: true |
Member
There was a problem hiding this comment.
Change to failed_when: false. Otherwise all good.
gregharvey
reviewed
Sep 2, 2025
| - name: Stop Sidekiq specifically first | ||
| ansible.builtin.command: | ||
| cmd: /opt/gitlab/bin/gitlab-ctl stop sidekiq | ||
| register: sidekiq_stop |
Member
There was a problem hiding this comment.
Actually, private vars it would be good if they begin with an underscore and the role name, e.g. _gitlab_sidekiq_stop would be a good variable name to use here.
|
gregharvey
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.