Skip to content

chore: Fix phpunit deprecations#9402

Merged
paulbalandan merged 2 commits into
codeigniter4:developfrom
neznaika0:chore/phpunit-config
Jan 14, 2025
Merged

chore: Fix phpunit deprecations#9402
paulbalandan merged 2 commits into
codeigniter4:developfrom
neznaika0:chore/phpunit-config

Conversation

@neznaika0

@neznaika0 neznaika0 commented Jan 12, 2025

Copy link
Copy Markdown
Contributor

Description

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@neznaika0

Copy link
Copy Markdown
Contributor Author

It is possible to specify a local version vendor/phpunit/phpunit/phpunit.xsd for better compatibility.

Comment thread tests/system/DebugTraceableTraitTest.php
@paulbalandan

Copy link
Copy Markdown
Member

It is possible to specify a local version vendor/phpunit/phpunit/phpunit.xsd for better compatibility.

Yes, this is what I'm doing in my libraries. It ensures you are using the latest schema of the phpunit version you are running.

@neznaika0

neznaika0 commented Jan 13, 2025

Copy link
Copy Markdown
Contributor Author

@paulbalandan sorry, offtop. Delete it after.

Who has access to the mail admin@codeigniter.com ? I have sent an email, but there is no response yet. Should I open a security PR?

EDIT: oh, send to security@codeigniter.com

@paulbalandan

Copy link
Copy Markdown
Member

@paulbalandan sorry, offtop. Delete it after.

Who has access to the mail admin@codeigniter.com ? I have sent an email, but there is no response yet. Should I open a security PR?

Thanks. I've asked in slack. I'll update once I got alternate email.

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label Jan 13, 2025
@paulbalandan

Copy link
Copy Markdown
Member

EDIT: oh, send to security@codeigniter.com

Yes, I've confirmed this. You can send your report there.

@paulbalandan paulbalandan merged commit d47a258 into codeigniter4:develop Jan 14, 2025
@neznaika0 neznaika0 deleted the chore/phpunit-config branch January 14, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants