Conversation
--hard-encoding-detection crashed if chardet picked an encoding that failed while reading, because only open() was wrapped and there was no fallback. Catch UnicodeDecodeError and LookupError from the chardet path, warn, and reuse the utf-8 / iso-8859-1 opener. Fixes codespell-project#3985
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3985
--hard-encoding-detectioncrashed when chardet chose an encoding that later failed to decode the file.open()itself rarely raisesUnicodeDecodeError; the failure happens while reading, and there was no fallback.The chardet path now:
UnicodeDecodeErrorandLookupErrorpropagateA test feeds a fake detector that reports
asciifor a UTF-8 file containingnaïveplus a typo, and checks that the file is still scanned as utf-8.