Warn when both pyproject.toml and .codespellrc configure codespell - #4032
Merged
Merged
Conversation
.codespellrc already overrides pyproject.toml, but the TOML file was omitted from the used-config list so the conflict was silent. Report both files and warn that the INI file wins. Fixes codespell-project#3999
Member
|
Nice, thanks @ekanshul |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3999
If both
pyproject.toml([tool.codespell]) and.codespellrc([codespell]) are present, only the later file is applied. The TOML file was not listed in "Used config files:" either, so the override was easy to miss.This change:
pyproject.tomlin the used-config list when it has a codespell table.codespellrctakes precedence--quiet-level=32(same bit as other config-file messages)A test covers the warning and the quiet-level suppression.