feat: thread context through Client request methods - #374
Merged
Conversation
Accept a context.Context on dbc.Client methods that issue HTTP requests (Search, Download, Install) and the internal helpers (makeRequest, getDriverListFromIndex, downloadPackage), so callers can cancel in-flight requests and propagate deadlines/tracing. Uninstall is unchanged as it makes no network calls.
Accept a context.Context on Credential.Refresh, Credential.GetAuthToken, auth.FetchColumnarLicense, auth.GetOpenIDConfig, refreshOauth, and the internal fetch helper so requests for license fetch and token refresh honor the caller's cancellation alongside makeRequest. Legacy makereq in drivers.go and cmd/dbc/auth.go TUI callers still pass context.Background / context.TODO since they have no caller-provided context yet.
amoeba
approved these changes
May 5, 2026
zeroshade
added a commit
that referenced
this pull request
May 20, 2026
…erge The merge of main brought in PR #374 which threaded context.Context through Client request methods. Two call sites added by this branch were missed by the merge: - cmd/dbc/driver_list.go:155 in GetDriverList — now passes context.Background() (matches the pattern used by drivers.GetDriverList and cmd/dbc/main.getDriverRegistry). - cmd/dbc/registry_wiring_test.go test stubs that mimic the production getDriverRegistry closure — match the production context.Background() call so the stubs faithfully reproduce the closure they replace. Build & Integrate (ubuntu/macos/windows), snapshot, and the per-platform build matrix were all failing on the same compile error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
context.Contextondbc.Clientmethods that issue HTTP requests (Search,Download,Install) and the internal helpers (makeRequest,getDriverListFromIndex,downloadPackage).makeRequestnow threads the passed context intohttp.NewRequestWithContextrather than usingcontext.Background().Uninstallis unchanged — it makes no network calls.drivers.GetDriverList,cmd/dbc/main.getDriverRegistry, tests) passcontext.Background()/t.Context().Test plan
go build ./...go vet ./...go test ./...