Repository navigation
Reject nested collections with a clear error - #245
Merged
Merged
Conversation
endel
added a commit
that referenced
this pull request
Oct 20, 2026
#245 prefixed the field by wrapping @type()'s normalization in a try/catch, so Metadata.setFields() and schema() threw without one, and unrelated errors (bad quantize options) got re-wrapped. getNormalizedType() takes the label instead, and checks once on the normalized result: a nested collection is always the outermost collection's direct child. Assisted-by: Claude Opus 5.5
Member
|
Thank you so much for the PR @vtxe02023274 - I've applied a few fixes on top of it and released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #212
A collection of collections (
{ map: { map: "number" } },{ map: { array: "string" } },[["string"]]) used to be accepted by@type()and then fail later with an unrelated error. Map of maps threwRight-hand side of 'instanceof' is not callableon the firstset(), and array of arrays did not throw at all until encoding.getNormalizedType()now rejects a collection whose child is another collection, and@type()prefixes the class and field, so the error points at the definition:t.*builders already rejected builders as element types, so this covers the decorator path. Collections of Schema classes are unchanged.Added tests in
Definition.test.ts.npm run test:mocha(1054 passing) andnpm run test:typespass locally.