Repository navigation
fix(parse): keep inline HTML content inside components and emphasis - #539
Conversation
|
Architecture Data flow Tip The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change 🪧 More tips
Thanks for using PR Lens! It's free for OSS. If it helped, a star helps other teams find it. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
@danielroe is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
comark
@comark/angular
@comark/ansi
@comark/html
@comark/nuxt
@comark/react
@comark/svelte
@comark/vue
commit: |
Merging this PR will not alter performance1 warning
Comparing |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
What
Note
context: this is one of a few fixes from round-tripping the Nuxt docs through
parseMarkdown->renderMarkdown.inline HTML inside a block component loses its content:
parses to
'Press Ctrl', ['kbd'], '+S', ['kbd'], ' to save.'. the same happens inside headings and emphasis anywhere (Press **<kbd>Ctrl</kbd>** to copy.), though a plain paragraph or list item is fine. an unclosed tag (Press <kbd>Ctrl to save.) gets hoisted around the whole component and swallows everything after it.component bodies, headings and emphasis don't nest into the HTML stack, so text never reaches a tag opened inside them, and nothing closes that tag when they end.
this PR gives component bodies the same
withHtmlScopethat list items and blockquotes use, and closes any tag still open at the end of a slot, heading or emphasis, the way a list item already does.