Repository navigation
fix(render): don't end a paragraph after an inline comment - #544
Conversation
|
Architecture Data flow No data-flow sequence changed in this PR. Tip Run 🪧 More tips
Thanks for using PR Lens! It's free for OSS. If it helped, a star helps other teams find it. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
@danielroe is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
comark
@comark/angular
@comark/ansi
@comark/html
@comark/nuxt
@comark/react
@comark/svelte
@comark/vue
commit: |
Merging this PR will not alter performance1 warning
Comparing |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
What
Note
context: this is one of a few fixes from round-tripping the Nuxt docs through
parseMarkdown->renderMarkdown.an inline comment splits its paragraph when rendered to markdown:
text <!-- note --> tailrenders as:
text <!-- note --> tailwhich comes back as two paragraphs. it's the same inside a component or a list item (where it also ends the list).
this passes the parent through from
one()and skips the separator when the comment is inline, using the same text-sibling check as themdchandler.