Py39 by ocefpaf · Pull Request #395 · conda-forge/python-feedstock

ocefpaf · 2020-10-06T17:53:35Z

Needs conda-forge/tzdata-feedstock#1
Closes #392

…nda-forge-pinning 2020.10.06.07.41.18

conda-forge-linter · 2020-10-06T17:53:41Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Co-authored-by: Isuru Fernando <isuruf@gmail.com>

mingwandroid · 2020-10-07T11:57:54Z

Yes, I developed a replacements thing recently just to get away from having to bash script or manually edit so much brittle stuff. Here's an example of it: https://github.com/AnacondaRecipes/qt-feedstock/blob/master/recipe/conda_build_config.yaml#L9-L28

ocefpaf · 2020-10-07T12:22:46Z

      run:
        - ld_impl_{{ target_platform }}  # [linux]
-        - tzdata
+        - python-tzdata


I thought that the idea was to avoid the python package and force Python to find the tzdata noarch generic, no?

This reverts commit b2cb64a.

ocefpaf · 2020-10-07T17:01:01Z

+         if os.name == 'nt':
+             _init_non_posix(_CONFIG_VARS)
+-            _CONFIG_VARS['TZPATH'] = ''
+            _CONFIG_VARS['TZPATH'] = os.path.join(_PREFIX, "share", "zoneinfo")


ocefpaf · 2020-10-07T17:08:51Z

@mingwandroid any final thoughts/consideration? Are we good to merge?

isuruf · 2020-10-07T17:11:55Z

@mingwandroid, I removed the hand edited sysconfigdata files as they were outdated and added code to generate the sysconfigdata for the system gcc and the conda compiler. Let me know if you are okay with that.

mingwandroid · 2020-10-07T18:06:47Z

I say go for it (then take cover)

mingwandroid · 2020-10-07T18:15:45Z

Oh one quick thing:

case "$target_Platform" in

does the case of the P matter here?

isuruf · 2020-10-07T18:16:37Z

yes, it does. fixed in f988bc8

ocefpaf · 2020-10-07T18:18:30Z

I say go for it (then take cover)

isuruf · 2020-10-07T19:26:11Z

Thanks @mingwandroid and @ocefpaf

ocefpaf · 2020-10-07T20:09:58Z

And you @isuruf! This one really took a village to get done!

ocefpaf · 2020-10-07T20:11:25Z

Also thanks to @pganssle for guiding us with the tzdata package and @mbargull for creating it!

mingwandroid · 2020-10-08T07:46:44Z

Great to see this land. From my perspective, it's the first time I've worked on a big update to Python within conda-forge in the first instance. That's of course the best way, esp. for the important packages.

It was a huge effort for many of us and of course its completion brings a whole bunch of other stuff to build, but with conda-forge's excellent tooling (and GitHub) that's not too scary a prospect.

For now, I must get 3.9.0 on defaults ASAP (I added tzdata and python-tzdata already - do we need both still? I got a bit confused around that bit!). I'll base it on the recipe here, and rebase the anaconda advertising patch to happen last (this makes patch rebasing easier). On that note, we should also talk about adopting the anaconda advertising method for conda-forge too instead of the conda-forge branding stuff, it is more reliable and involves less file IO at interepreter launch time, pinging @jjhelmus on the reliability matter). CMake detects our tools now (thanks KitWare!) and will increasingly do so so having some more uniformity around this stuff would be good.

Keep on keeping on conda-forge.

ocefpaf · 2020-10-08T11:32:18Z

For now, I must get 3.9.0 on defaults ASAP (I added tzdata and python-tzdata already - do we need both still?

To build python we only need tzdata. We also offer python-tzdata b/c some packages may want to use it. They do share the same zoneinfo data now.

I got a bit confused around that bit!). I'll base it on the recipe here, and rebase the anaconda advertising patch to happen last (this makes patch rebasing easier). On that note, we should also talk about adopting the anaconda advertising method for conda-forge too instead of the conda-forge branding stuff, it is more reliable and involves less file IO at interepreter launch time, pinging @jjhelmus on the reliability matter). CMake detects our tools now (thanks KitWare!) and will increasingly do so so having some more uniformity around this stuff would be good.

Sure. I don't really know what that entails but it sounds like something we could do.

mbargull · 2020-10-08T12:04:16Z

Great to see this land. From my perspective, it's the first time I've worked on a big update to Python within conda-forge in the first instance. That's of course the best way, esp. for the important packages.

🎉

(I added tzdata and python-tzdata already - do we need both still? I got a bit confused around that bit!).

Yep, like Felipe said, it makes sense to have both. python-tzdata isn't really important for our Python distribution, because with tzdata we should ship everything zoneinfo needs. But we'll probably see (few?) other packages that may add python-tzdata as a dependency in the future.

Keep on keeping on conda-forge.

🤘

Sure. I don't really know what that entails but it sounds like something we could do.

Same here, agreed! Best thing would probably be to just open a PR whenever you're ready and discuss details there.

Superharz · 2020-10-08T15:39:02Z

Hello,

I'm running on a 64-Bit Windows 10 v. 1909

I just tried to install python 3.9.0 in a new empty Conda Env (named new2).
However, I always get the following error:

mingwandroid · 2020-10-08T16:43:12Z

You should use: conda config --set add_pip_as_python_dependency false

.. at least until pip is rebuilt.

(everyone should use this, always IMHO)

Superharz · 2020-10-08T17:47:21Z

You should use: conda config --set add_pip_as_python_dependency false

.. at least until pip is rebuilt.

(everyone should use this, always IMHO)

@mingwandroid Thank you. That solved my problem.

ocefpaf added 3 commits October 6, 2020 14:50

update to 3.9

e65c773

MNT: Re-rendered with conda-build 3.20.3, conda-smithy 3.7.10, and co…

8d6d11a

…nda-forge-pinning 2020.10.06.07.41.18

re-add tzdata

8da0ada

ocefpaf requested review from isuruf, jakirkham, jjhelmus, mingwandroid, msarahan, pelson and scopatz as code owners October 6, 2020 17:53

isuruf reviewed Oct 6, 2020

View reviewed changes

Comment thread recipe/meta.yaml Outdated

isuruf reviewed Oct 6, 2020

View reviewed changes

Comment thread recipe/patches/0001-Darwin-Add-arch-x86_64-to-UnicCCompiler-ld_args.patch Outdated

Update recipe/meta.yaml

8a49f9d

Co-authored-by: Isuru Fernando <isuruf@gmail.com>

isuruf reviewed Oct 6, 2020

View reviewed changes

Comment thread recipe/patches/gh21228.patch

restore patch

cc8e873

ocefpaf force-pushed the py39 branch from b562eab to 5101390 Compare October 6, 2020 22:18

revert patch

13e1e36

ocefpaf force-pushed the py39 branch from 5101390 to 13e1e36 Compare October 6, 2020 22:50

tzdata path

a683dc1

ocefpaf force-pushed the py39 branch from fd390f1 to a683dc1 Compare October 7, 2020 00:09

isuruf added 5 commits October 6, 2020 21:56

asd

754248f

update sysconfig data for linux-x86

cd61f4e

fix sysconfigdata

06493b2

Fix conda_cos6

16e811d

Fix typo

3f5209f

ocefpaf commented Oct 7, 2020

View reviewed changes

Comment thread recipe/sysconfigdata/default/_sysconfigdata_linux.py Outdated

tzdata => python-tzdata

b149e6b

ocefpaf commented Oct 7, 2020

View reviewed changes

mingwandroid and others added 11 commits October 7, 2020 14:41

Skip stripping on osx arm64

b2cb64a

Force eol for recipe/tests/prefix-replacement/build-and-test.sh

cde13cf

fix another typo

75c28fb

get rid of hand edited sysconfigdata

db61f52

Use non python tzdata

d2b586b

Fix SGI_ABI

52e9d6a

fix typo

f988bc8

Fix TZPATH on windows

baa1862

Revert "Skip stripping on osx arm64"

bd99141

This reverts commit b2cb64a.

replace - with _

2faf5e0

need CPPFLAGS with -I. -isystem is not enough

362e1bc

jjhelmus mentioned this pull request Oct 7, 2020

V3.8.6 #396

Merged

ocefpaf commented Oct 7, 2020

View reviewed changes

isuruf merged commit e7ea437 into conda-forge:master Oct 7, 2020

ocefpaf deleted the py39 branch October 7, 2020 20:09

Uh oh!

Uh oh!

Conversation

ocefpaf commented Oct 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conda-forge-linter commented Oct 6, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mingwandroid commented Oct 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocefpaf Oct 7, 2020

Choose a reason for hiding this comment

Uh oh!

ocefpaf Oct 7, 2020

Choose a reason for hiding this comment

Uh oh!

ocefpaf commented Oct 7, 2020

Uh oh!

isuruf commented Oct 7, 2020

Uh oh!

mingwandroid commented Oct 7, 2020

Uh oh!

mingwandroid commented Oct 7, 2020

Uh oh!

isuruf commented Oct 7, 2020

Uh oh!

ocefpaf commented Oct 7, 2020

Uh oh!

isuruf commented Oct 7, 2020

Uh oh!

ocefpaf commented Oct 7, 2020

Uh oh!

ocefpaf commented Oct 7, 2020

Uh oh!

mingwandroid commented Oct 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocefpaf commented Oct 8, 2020

Uh oh!

mbargull commented Oct 8, 2020

Uh oh!

Superharz commented Oct 8, 2020

Uh oh!

mingwandroid commented Oct 8, 2020

Uh oh!

Superharz commented Oct 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ocefpaf commented Oct 6, 2020 •

edited

Loading

mingwandroid commented Oct 7, 2020 •

edited

Loading

mingwandroid commented Oct 8, 2020 •

edited

Loading