Skip to content

remove top pycodestyle pin - #7

Closed
bollwyvl wants to merge 2 commits into
conda-forge:masterfrom
bollwyvl:patch-1
Closed

bollwyvl wants to merge 2 commits into
conda-forge:masterfrom
bollwyvl:patch-1

Conversation

@bollwyvl

Copy link
Copy Markdown

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Notes:

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bollwyvl

Copy link
Copy Markdown
Author

@conda-forge-admin please rerender

@ccordoba12

Copy link
Copy Markdown
Contributor

Hey @bollwyvl, I'm afraid this requires a new release of pylsp-server. And that, in turn, requires that we support flake8 4 there.

You're welcome to give us a hand with those things, if you have time.

@ccordoba12 ccordoba12 closed this Oct 26, 2021
@bollwyvl

Copy link
Copy Markdown
Author

Hm, was just going off the upstream setup.py, which does not have the top pin. If you've got some existing issue to look at, might be able to take a gander, but am pretty slam-bammed right now. Indeed, today we're just trying to eke out conda-forge/jupyter-lsp-feedstock#35, where we hope adding a run_constrained of autopep8 does the thing for us.

Of note, this still runs afoul of the linked autopep8 PR:

autopep8 1.6.0 has requirement pycodestyle>=2.8.0, but you have pycodestyle 2.7.0.

@ccordoba12

Copy link
Copy Markdown
Contributor

I think the constraint on pycodestyle is put by flake8. So the only solution is to update our requirement on it.

@ericpre ericpre mentioned this pull request Nov 13, 2021
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants