Skip to content

feat: allow building ConductorWorkflow without an executor - #521

Open
Apeksha9389 wants to merge 2 commits into
conductor-oss:mainfrom
Apeksha9389:feat/optional-workflow-executor
Open

Apeksha9389 wants to merge 2 commits into
conductor-oss:mainfrom
Apeksha9389:feat/optional-workflow-executor

Conversation

@Apeksha9389

Copy link
Copy Markdown

Fixes #432

ConductorWorkflow required a live WorkflowExecutor, so building or serializing a definition (e.g. in unit tests) needed a server. executor is now optional (the positional order is unchanged and name is still required). register(), start_workflow(), start_workflow_with_input() and execute() raise a RuntimeError pointing to executor= when none was given.

Testing: added tests/unit/workflow/test_conductor_workflow_offline.py (6 tests: offline to_workflow_def(), name still required, the three executor-backed methods raise, positional executor still used); 4 fail without the change. Unit suite: 2566 passed; the 17 failures in tests/unit/ai are the same on main.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ConductorWorkflow requires a live executor at construction time — prevents offline use

1 participant