No generic in JStreamParallelStreamProcessor factory method #486

Activity

1. astubbs commented on Nov 30, 2022

   

   Antony Stubbs (astubbs)

   on Nov 30, 2022

   Contributor

   More actions

   Hi! You’re the first person to ever ask about this interface :)
   Aside from your question, may I know why this interface is your preference?
   I’ll take a look soon.
2. acktsap commented on Dec 1, 2022

   

   Taeik Lim (acktsap)

   on Dec 1, 2022

   ContributorAuthor

   More actions

   Thanks for reply!

   Actually i don't use it. I just think it would be better to keep consistency with ParallelStreamProcessor.

   parallel-consumer/parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/ParallelStreamProcessor.java

   Lines 25 to 27 in 540b0b9

   	static <KK, VV> ParallelStreamProcessor<KK, VV> createEosStreamProcessor(ParallelConsumerOptions<KK, VV> options) {
   	return new ParallelEoSStreamProcessor(options);
   	}
3. astubbs commented on Dec 2, 2022

   

   Antony Stubbs (astubbs)

   on Dec 2, 2022

   Contributor

   More actions

   Yes, def. I'll fix it. But I'm also thinking about removing the Stream interfaces.
4. Antony Stubbs (astubbs)

   added a commit that references this issue on Dec 7, 2022

   minor: fixes #486: Missing generics in JStreamParallelStreamProcessor

   This issue will close once commit d5b7911 is merged into the 'master' branch.

   d5b7911
5. Antony Stubbs (astubbs)

   closed this as completedin #491on Dec 7, 2022
6. Antony Stubbs (astubbs)

   added a commit that references this issue on Dec 7, 2022

   minor: fixes #486: Missing generics in JStreamParallelStreamProcessor

   This issue will close once commit 315b7f6 is merged into the 'master' branch.

   315b7f6