Repository navigation
Update Jenkinsfile Nodelabel - #169
Closed
James Kao (jkao97) wants to merge 3 commits into
Closed
James Kao (jkao97) wants to merge 3 commits into
James Kao (jkao97) wants to merge 3 commits into
Conversation
Contributor
|
hi James Kao (@jkao97) , does it need to be jdk 11? |
Antony Stubbs (astubbs)
force-pushed
the
master
branch
from
October 13, 2021 16:56
bdc2932 to
84cf11a
Compare
Antony Stubbs (astubbs)
force-pushed
the
master
branch
2 times, most recently
from
February 16, 2022 17:41
4c62a9f to
b5b166f
Compare
Addresses issues reported: - ConcurrentModificationException in ShardManager during Rebalancing confluentinc#188 - NullPointerException in PartitionMonitor during Rebalancing confluentinc#189 Notes: - Improve impact of no-op removed state, so it won't be retrieved for analysis - Change from removing revoked PartitionState instances to replacing with a PartitionRemovedState subclass -- Advantage of this is there will never be NPE from stale references of work still in flight -- Also means we can track history of assignment - Several refactorings that have been waiting to happen related to the change - Improved cohesion Relates / Future improvements on this: Refactor: Consider a shared nothing architecture, to reduce thread complexity confluentinc#200
Contributor
|
Grace Chen (@gracechensd) do you know? |
Member
|
Unsure, I would default to James Kao (@jkao97) on this |
Author
|
currently yes, jdk13 is no longer supported. |
Antony Stubbs (astubbs)
force-pushed
the
master
branch
from
March 4, 2022 13:26
5be0137 to
84c7522
Compare
Antony Stubbs (astubbs)
force-pushed
the
master
branch
from
March 23, 2022 13:49
3905c7c to
3dcb9d7
Compare
Contributor
|
Supersceded by: |
Antony Stubbs (astubbs)
added a commit
to astubbs/parallel-consumer
that referenced
this pull request
Aug 20, 2026
…o and do not close The triage split its cohort: ten mirrors with no fix got an agent and a note each, and four that already had one were checked for a different thing - does the PR actually close the issue. That second check happened in a session and was never written down, which is the exact defect the companion note documents. A finding that lives only in scrollback dies with the session. Two need an edit before merge. #201 carries no closing reference and describes itself as fixing "the log-noise half" of #155, but both the issue and the PR say the other half was already fixed elsewhere, so there is no remainder and the issue would outlive its own fix. #203 does close its two issues, in the bare `Closes #169` form that docs/issue-references.md forbids for anything posted to GitHub - confluentinc#169 and confluentinc#170 exist and mean other things, so a human reading that body is guessing. #204 needs no change: it deliberately does not close #177, and says why. The gap there is on the issue, which has no comments, so the reasoning for why it survived its own merged fix is visible only inside the PR body. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFRbSkHwaRw6YYFHHBWZ7p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.