Repository navigation
fix: After new performance fix PR#530 merges - corner case could cause out of order processing - #534
Merged
Merged
Conversation
Under unrealistically high load with no-op processing, broker poller unblocking a partition could cause ProcessingShard to skip forward in its entries and take work out of order. Was discovered when fixing a synthetic high performance benchmark, after an O(n) algo was fixed to O(1), creating the state for the race condition to appear. Probably could not happen without the fix, as it's related to the performance of certain parts of the system.
Antony Stubbs (astubbs)
force-pushed
the
fixes/unblock-race
branch
from
December 29, 2022 15:09
da9f879 to
6f6d7fb
Compare
Antony Stubbs (astubbs)
marked this pull request as ready for review
December 29, 2022 15:09
Antony Stubbs (astubbs)
changed the title
Antony Stubbs (astubbs)
changed the title
Antony Stubbs (astubbs)
changed the title
Antony Stubbs (astubbs)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
Checklist