Skip to content

Laravel 8 support#94

Merged
jgrossi merged 8 commits into
corcel:masterfrom
squatto:laravel-8-support
Oct 31, 2020
Merged

Laravel 8 support#94
jgrossi merged 8 commits into
corcel:masterfrom
squatto:laravel-8-support

Conversation

@squatto

@squatto squatto commented Oct 14, 2020

Copy link
Copy Markdown
Contributor

This adds support for Laravel 8.x by way of adding support for Corcel 5.x (added by Corcel PR #531). The PHPUnit version constraints were changed to line up with Laravel 8's PHPUnit version constraints.

I based this branch on master because develop isn't in sync with master yet (#93 brings them in sync but it isn't merged yet)

Also bumped PHPUnit from `^8.0` to `^8.4` to match Laravel 8
@squatto

squatto commented Oct 14, 2020

Copy link
Copy Markdown
Contributor Author

This build fails because it's using PHP 7.2, and Laravel 8 requires >=7.3. I left >=7.2 as the PHP version constraint to allow Corcel 4.x to be used, and added a "PHP" column to the newly-added "Version Compatibility" section in the readme:

https://github.com/squatto/acf/blob/c01a5d4e5331a329df16e21d090886f7b3327667/readme.md#L22-L27

Version Compatibility

Corcel Laravel PHP
^4.0 7.x >=7.2
^5.0 8.x >=7.3

EDIT: I adjusted the travis builds to test v4 against 7.2, 7.3, and 7.4 and v5 against 7.3 and 7.4. All builds are passing now 👍🏻

* Corcel v4 tested with PHP 7.2, 7.3, and 7.4
* Corcel v5 tested with PHP 7.3 and 7.4
* Removed deprecated/ignored `sudo` setting
* Moved database import process into `before_script`
* Moved `composer self-update` into `before_install`
* Moved `composer install` into `install`
@squatto

squatto commented Oct 14, 2020

Copy link
Copy Markdown
Contributor Author

If you can't tell, this is my first foray into Travis builds. Sorry for the barrage of commits and builds!!

@jgrossi
jgrossi merged commit a96ed6a into corcel:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants