Repository navigation
feat: add optional BLE MIDI support for ESP32 - #190
Open
godden-sys wants to merge 16 commits into
Open
godden-sys wants to merge 16 commits into
godden-sys wants to merge 16 commits into
Conversation
…en-sys/edrumulus into fix/clang-format-violations
…en-sys/edrumulus into fix/clang-format-violations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The main objective of this PR is to implement BLE-MIDI (Bluetooth Low Energy MIDI) support for the ESP32 platform, enabling wireless MIDI capabilities.
Additionally, this PR standardizes function scopes and link flags to ensure that adding this feature does not break compilation on other physical hardware targets (such as Teensy boards and custom ESP32-S3 setups).
Main Feature Implemented
Target Fixes & CI Compatibility Changes
preset_settings(),write_all_settings(), andread_settings()) outside exclusive#ifdefblocks. This prevents scope errors on environments without Bluetooth (like Teensy boards or specific ESP32-S3 environments).-Wl,--allow-multiple-definitionflag to the[env:esp32-s3-devkitc-1]environment. This resolves duplicate definition conflicts between the official Espressif core USB libraries and theAdafruit TinyUSB Library.All physical targets are now successfully passing local
clang-formatand building withSUCCESS. Note that thearduino-latestcheck failure is a known upstream repository issue (missingplatformio-build.py) and is unrelated to these changes.