Fix blank numpy-typed columns in native Qt ClusterView (#1377)#1378
Merged
rossant merged 1 commit intoJun 15, 2026
Merged
Conversation
_TableModel.data() returned numpy scalars (np.int64/np.float64) for the id/sh/depth/amp columns, which Qt's model/view renders as blank cells. Convert numpy scalars to native Python via .item() so they display, while native-Python columns (ch/fr/n_spikes/Amplitude) pass through unchanged. Fixes cortex-lab#1377.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phy 2.1.0rc1's rewritten native-Qt ClusterView (release-2.1) renders the numpy-typed columns (id / sh / depth / amp) as BLANK cells, while the native-Python columns (ch / fr / n_spikes / Amplitude) display fine.
Cause:
_TableModel.data()returns numpy scalars (np.int64 / np.float64) to Qt's model/view, which cannot display them and shows empty cells.Fix: convert numpy scalars to native Python via
.item()indata(). Thehasattr(value, 'item')guard means native-Python values (which lack.item()) pass through unchanged, so only the affected numpy columns are touched.Tested on phy 2.1.0rc1 with a KiloSort4 sort: id/sh/depth/amp now display correctly and the previously-working columns are unaffected.
Fixes #1377.