Lorenze/fix/issue 4472 - #4601
Closed
lorenzejay wants to merge 8 commits into
Closed
Conversation
Tool parameter schemas were stripping null from optional fields via
generate_model_description, forcing the LLM to provide non-null values
for fields.
Adds strip_null_types parameter to generate_model_description and passes False when generating tool
schemas, so optional fields keep anyOf: [{type: T}, {type: null}]
Co-authored-by: Gabe Milani <gabriel@crewai.com>
* Added a new utility function to remove OpenAI-specific fields from schemas, ensuring compatibility with Gemini and Bedrock APIs. * Updated BedrockCompletion and GeminiCompletion classes to utilize this function for cleaning parameters before API calls. * Introduced tests to validate the functionality of the new utility, ensuring it correctly strips incompatible fields while preserving required properties.
lucasgomide
approved these changes
Feb 26, 2026
greysonlalonde
left a comment
greysonlalonde
left a comment
Contributor
There was a problem hiding this comment.
ag2ai/ag2#2421 this has since been fixed gemini side; anthropic does support/require additionalProperties during strictness
Contributor
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on top of: #4579
address: #4472