Jenkins integration - #1
Open
Brian Hyams (brianhy) wants to merge 12 commits into
Open
Conversation
No changes to the project itself yet.
When this is present the build will break on the mac b/c it doesn't have .net 4.6 installed. Instead of trying to work around that (which isn't needed since we want netstandard for .net core support), we instead deprecate it. We didn't go so far as to remove the .Net framework dirs as that would result in lots of git merge issues if we take new drops from master.
|
🚀 This PR has been checked for open source licensing and security compliance. Analysis Results: For more information, see: |
In Jenkins, a PR isn't run from the branch, so the releaseBranch check wasn't doing anything. Instead, we'll just always run the publish to test publish to artifactory.
Brian Hyams (brianhy)
force-pushed
the
jenkins-integration
branch
from
April 16, 2020 17:01
ccfc99a to
41a1948
Compare
Nuget publish succeeded, but I don't see it in nuget. The log output makes me wonder if the build # is problematic: > 12:01:45 Build successfully deployed. Browse it in Artifactory under https://csdisco.jfrog.io/csdisco/webapp/builds/csdisco-ical-net%20::%20PR-1/3
Now that build description will include build version, we need to feed that to the build.ps1 to keep those in sync.
Brian Hyams (brianhy)
force-pushed
the
jenkins-integration
branch
from
April 16, 2020 18:32
cabe20b to
b759e7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preliminary Jenkins integration
Jenkins will need this checked in before it'll actually run, so we need to check-in, then run, then debug any issues.