Repository navigation
test(web): run axe on a saved planner show - #487
Merged
Merged
Conversation
The form for a new show had an axe check, and the page for a saved one, with its lineup rows, didn't. Fixes LOC-185
bnb
approved these changes
Nov 7, 2026
SizeCompared with main. KiB are 1,024 bytes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes LOC-185.
Added
/dashboard/planner/shows/[rkey]in the planner inquiry e2e test, right after the show is saved, so the page has a lineup with its slot, status, inquire and remove controls. The new show form already had one.How it was tested
The test passes on chromium, so the page has no WCAG 2.1 A or AA violations axe can find, with a lineup of one. With the
aria-labeltaken off the status select it fails withselect-nameonselect[name="slotStatus"].