Repository navigation
fix(localtoolbox): keep an artist's profile when a lookup fails - #490
Open
botandbang wants to merge 1 commit into
Open
botandbang wants to merge 1 commit into
botandbang wants to merge 1 commit into
Conversation
Every lookup that wasn't a 401 landed in `failed`, the panel turned that into `unavailable`, and the store overwrote the profile. A row with a bio and links then said "no public profile" until someone pressed look up again, and a new row read as a private account. The page now answers `missing` when SoundCloud says nobody is there and `failed` when it couldn't ask. Only `missing` reaches the store. A failed row keeps what it had and says "lookup failed", which isn't stored. Fixes LOC-220
github-actions
Bot
added
documentation
bnb
approved these changes
Nov 7, 2026
SizeCompared with main. KiB are 1,024 bytes.
|
Coverage Report for apps/localtoolbox
File Coverage
SizeCompared with main. KiB are 1,024 bytes.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes LOC-220
Pressing look up again while
/resolvefailed (offline, a 5xx, a 429 past its retries) landed infailed, the panel turned that intounavailable: true, andlearnoverwrote the profile.Added
missinginProfilesAnswerandProfilesProgress: paths SoundCloud answered for, with a 404 or something that isn't a user.Changed
failednow means the lookup couldn't ask. Those answers don't reach the store, so a profile stays, and a new row stays not looked up and is offered for the next lookup.docs/artists.md.