Repository navigation
fix(localtoolbox): send from the queue to the open tool, and say what the state file holds - #491
Open
botandbang wants to merge 1 commit into
Open
botandbang wants to merge 1 commit into
botandbang wants to merge 1 commit into
Conversation
… the state file holds Sending from the queue sheet to the tool already open only closed the sheet: the sheet and the panel each had their own copy of the source preference, and the same tool remounts nothing. The source is now one object, as the Downloader's settings are, and the Downloader's list follows it whoever changes it. The note after an import said to reload the tab, though an open tab repaints marks at once, and the sheet said the file holds everything the extension has saved, though it holds three options. Comments that drifted the same way are fixed with them. Fixes LOC-219 Fixes LOC-223 Fixes LOC-228
github-actions
Bot
added
localtoolbox
Coverage Report for apps/localtoolbox
File Coverage
SizeCompared with main. KiB are 1,024 bytes.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
bnb
approved these changes
Nov 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes LOC-219
Fixes LOC-223
Fixes LOC-228
Sending to the open tool. The sheet set its own copy of the preference,
persisted()keeps separate state per call, and the same tool id remounts nothing.Added:
sourcein$lib/source.ts, the one object all three share, asdownloader.svelte.tsdoes for its settings. An effect in the Downloader that collects again when the source changes, whoever changed it.Removed: the
sourceandonchangeprops ofSourcePicker, and theSOURCESexport.State file text. Changed: the note after an import no longer says to reload the tab, since an open tab repaints marks at once. The sheet and the Manager's button title say "your marks, lists, queue and a few options" instead of everything, since the file carries three options.
Comments. Changed:
content.ts(the press comes before the queue),prefs.svelte.ts(three keys are in the file),SettingsSheet.svelte,StateTransfer.svelteandstate-transfer.ts(not everything), the playlist panel ("your likes"), andqueue.svelte.ts(a queued button, not a pill).