Repository navigation
Expand CODEOWNERS to require expertise-matched review on PRs #848
Description
Following up from our working group meeting on the PR approval process: we agreed to expand .github/CODEOWNERS so that, once branch protection is enabled, pull requests touching specific areas of the codebase will automatically require review from people with the relevant expertise.
Note: this change alone doesn't enforce anything yet, since branch protection rules aren't turned on for this repo. It's a necessary step before we turn those on and expand who can approve PRs.
I'll follow up with a PR once we've settled on the mapping of paths to reviewers (eg /src/ → Neil and /Rules/languages → translator team).
Reference: GitHub documentation on code owners
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
chore: expand CODEOWNERS with path-based review assignments
rileeki commentedon Oct 5, 2026
Question for the team: do we want everyone on the Daisy mathcat-translators team to be allowed to approve translation PRs, or create a smaller list of more experienced translators? @MartheGjelstad and @Johannes-spsm, any opinions?
MartheGjelstad commentedon Oct 6, 2026
Hmm, I am not sure. Most translators make pull requests to their translation branch. Then Neil accepts the PR and merge it into main. Do we need to look at this process? An item for the working group?
Anyway, we always need to make sure that the unit tests pass before merging changes to a translation into main.
rileeki commentedon Oct 6, 2026
Ah, thanks @MartheGjelstad. I hadn't realized these long-lived language branches were being used this way. The documentation says to "Open a pull request against the main MathCAT repository", and I assumed that meant translators were opening PRs to
main.I do think it would be helpful to clarify that process, both to make sure the process is clear and consistent with the documentation and to make sure the ruleset changes we're proposing for themainbranch are serving the right goals. In our discussions about PR approvals, I was just focusing on approving changes tomain, and am now worried I misunderstood.MartheGjelstad commentedon Oct 7, 2026
You did not misunderstand. We were always talking about approving changes to
main. I forgot about the different language branches.I think the reason for making PRs to the language branches is to make sure everything in
mainalways pass. Now that we are looking into how things should be merged into main, these language branches might not be necessary anymore, except when you start to work on a new translation.