Repository navigation
Add TTS::get_string helper to dedupe engine dispatch - #908
Merged
Merged
Conversation
The three-way match on TTS::None/SSML/SAPI5 to call get_string_none / get_string_ssml / get_string_sapi5 was repeated. Move it into a single get_string helper so adding a new engine only needs one match updated.
Linux library size: 0.59 MiB (-0.01%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three-way match on TTS::None/SSML/SAPI5 to call get_string_none / get_string_ssml / get_string_sapi5 was repeated. Move it into a single get_string helper so adding a new engine only needs one match updated.