Skip to content

function is_generalized_salt only returns false every time - #910

Merged
NSoiffer merged 2 commits into
daisy:mainfrom
moritz-gross:remove-trivial-function--is-generalized-salt
Oct 24, 2026
Merged

NSoiffer merged 2 commits into
daisy:mainfrom
moritz-gross:remove-trivial-function--is-generalized-salt

Conversation

@moritz-gross

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

Copy link
Copy Markdown
Linux library size: 0.59 MiB (+0.00%)
Revision Release liblibmathcat.so
Base (3aee7a4) 0.59 MiB (614,768 bytes)
PR (59849c0) 0.59 MiB (614,784 bytes)
Change +16 bytes (+0.00%)

Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run.

@NSoiffer

Copy link
Copy Markdown
Collaborator

It appears that I never got around to implementing is_generalized_salt. I asked AI if the implementation would be complicated and it said "yes". I'll take that as "it's not worth it".

@NSoiffer
NSoiffer merged commit 220eb78 into daisy:main Oct 24, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this from Triage to Done in MathCAT Project Board Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants